Add call classification and supported kind to data extensions editor#2563
Add call classification and supported kind to data extensions editor#2563
Conversation
This removes the call type as shown for an unmodelable method. We still need to decide how to show this information, so this may be added back in later.
koesie10
force-pushed
the
koesie10/classification
branch
from
ca86840 to
6a0cae5
Compare
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
No comments on how the code is written. That all looks great.
My only comment on the styling is whether the classification labels are a bit too large and prominent, and if it makes the view more cluttered. It's the default styling so it's definitely not your fault, but they maybe stand out slightly too much and distract from other elements, and it's unhelpful that they look almost exactly the same as the clickable buttons.
However, I'd be happy to proceed as this is now, with the understanding that we'll be doing a design review once we get to the end of this current implementation work.
| <ViewLink onClick={jumpToUsage}>View</ViewLink> | ||
| {!inSource && ( | ||
| <ClassificationsContainer> | ||
| {inTest && <VSCodeTag>Test</VSCodeTag>} |
There was a problem hiding this comment.
Random thought. Is it possible to put a tooltip / title text on these that explains "This method is only used from test code"?
I agree, the tags are a little bit big. I've made their text sizes smaller so they stand out less, so this should hopefully partly fix that. I've also added the tooltip you suggested. Unfortunately, the webview UI toolkit doesn't have a tooltip component, so it's just a |
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
LGTM
Thanks for those styling tweaks, and putting the classification code in a new component looks good.
2 participants
This will add a "Test" or "Generated" tag on the method if it's only used in tests or generated code and not in the actual application source code. It also adds retrieving the method "type" (e.g. source or sink) to the queries, but does not show these yet.
Checklist
ready-for-doc-reviewlabel there.