Skip to content

Rename PathTable => AlertTable#2570

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/AlertTable-rename
Jul 3, 2023
Merged

Rename PathTable => AlertTable#2570
robertbrignull merged 1 commit intomainfrom
robertbrignull/AlertTable-rename

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

In preparation for converting PathTable to a function component, rename it to a clearer name.

The file is called alert-table.tsx and I think that AlertTable is a more understandable name than PathTable. This table is used whenever there are "SarifInterpretationData", which includes problem and path-problem queries.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertbrignull robertbrignull merged commit 6acfb8d into main Jul 3, 2023
@robertbrignull robertbrignull deleted the robertbrignull/AlertTable-rename branch July 3, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants