Update data extensions modelling table title bar#2574
Merged
robertbrignull merged 2 commits intomainfrom Jul 4, 2023
Merged
Conversation
robertbrignull
commented
Jul 3, 2023
| externalApiUsages={grouped[libraryName]} | ||
| modeledMethods={modeledMethods} | ||
| mode={mode} | ||
| hasUnsavedChanges={false} |
Contributor
Author
There was a problem hiding this comment.
I've made this hidden by default, but to see it for testing just change this to true. You can use the "Data extensions editor" storybook to view it.
We could also add a storybook for the LibraryRow component, if that would be helpful.
shati-patel
approved these changes
Jul 4, 2023
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
LGTM! We can always adjust how we handle the buttons later, if need be 😎 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the title bar of the modelling tables to match the new designs:
I removed the old status info, since that is not present in the new designs.
A lot of manual styling was needed to get these new elements looking like the designs. Hopefully that's ok, but if it's too complicated or it's straying a bit too far from VS Code design principles then we can look at that.
The "Model with AI" / "Model from source" buttons and the "UNSAVED" label aren't hooked up to anything yet, but we'll get to those in a later PR. I gave them all no-op handlers for now. Since the data extensions view is not released yet we're not too worried about how the view looks while this work is in progress.
Checklist
ready-for-doc-reviewlabel there.