Skip to content

Use more varied data for the number of usages#2575

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/data-editor-story
Jul 4, 2023
Merged

Use more varied data for the number of usages#2575
robertbrignull merged 1 commit intomainfrom
robertbrignull/data-editor-story

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

The main goal here is making the number of usages not all be single-digit numbers. This helps show up errors in the column alignment of the table much more easily.

Rather than writing out each array element, I'm using Array(10).fill(...) to create an array of arbitrary size. Each element of the array will be the same object, but I think that's fine for this story.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team as a code owner July 4, 2023 10:24
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robertbrignull robertbrignull enabled auto-merge July 4, 2023 11:01
@robertbrignull robertbrignull merged commit 12e9de8 into main Jul 4, 2023
@robertbrignull robertbrignull deleted the robertbrignull/data-editor-story branch July 4, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants