Add ability to record and replay mock code search requests#2576
Merged
Conversation
norascheuch
approved these changes
Jul 4, 2023
Contributor
norascheuch
left a comment
norascheuch
left a comment
There was a problem hiding this comment.
This is great! Haven't tested but looks good code-wise!
charisk
force-pushed
the
charisk/mock-api-code-search
branch
from
22bc77a to
8a28da2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to record and replay mock code search requests and also added a scenario that can be loaded in using the mock server.
Note that the mock API server stuff are currently in /variant-analysis and ideally they'd be more generic, but I'll leave that as tech debt for now.
Checklist
N/A:
ready-for-doc-reviewlabel there.