Skip to content

Data extensions UI: Add save button #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shati-patel merged 1 commit into from
Jul 4, 2023
Merged

Data extensions UI: Add save button #2579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions extensions/ql-vscode/src/view/data-extensions-editor/LibraryRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const TitleContainer = styled.button`
cursor: pointer;
`;

const TitleDivider = styled(VSCodeDivider)`
const SectionDivider = styled(VSCodeDivider)`
padding-top: 0.3rem;
padding-bottom: 0.3rem;
`;
Expand Down Expand Up @@ -64,6 +64,13 @@ const TitleButton = styled(VSCodeButton)`
}
`;

const ButtonsContainer = styled.div`
display: flex;
gap: 0.4em;
justify-content: right;
margin-bottom: 1rem;
`;

type Props = {
title: string;
externalApiUsages: ExternalApiUsage[];
Expand Down Expand Up @@ -104,6 +111,11 @@ export const LibraryRow = ({
e.preventDefault();
}, []);

const handleSave = useCallback(async (e: React.MouseEvent) => {
e.stopPropagation();
e.preventDefault();
}, []);

return (
<LibraryContainer>
<TitleContainer onClick={toggleExpanded} aria-expanded={isExpanded}>
Expand All @@ -130,13 +142,17 @@ export const LibraryRow = ({
</TitleContainer>
{isExpanded && (
<>
<TitleDivider />
<SectionDivider />
<ModeledMethodDataGrid
externalApiUsages={externalApiUsages}
modeledMethods={modeledMethods}
mode={mode}
onChange={onChange}
/>
<SectionDivider />
<ButtonsContainer>
<VSCodeButton onClick={handleSave}>Save</VSCodeButton>
</ButtonsContainer>
</>
)}
</LibraryContainer>
Expand Down