Show more clearly when a method is already modeled#2600
Merged
robertbrignull merged 11 commits intomainfrom Jul 12, 2023
Merged
Show more clearly when a method is already modeled#2600robertbrignull merged 11 commits intomainfrom
robertbrignull merged 11 commits intomainfrom
Conversation
norascheuch
approved these changes
Jul 12, 2023
Contributor
norascheuch
left a comment
There was a problem hiding this comment.
I'm a bit confused by the diff of 'Pull out ModelableMethodRow as a separate component' but I think it looks good, otherwise just 2 minor comments. Looks good!
Contributor
Author
Yeah it's a little hard to understand because the git diff algorithm realised it's less change to say we split the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does some refactoring of the
MethodRowcomponent to split it into two cases:We then finally add a simple message saying that a method is already modeled and cannot be edited.
The refactoring is not strictly necessary, and I can remove it or pull it out to two separate PRs if that would be easier. What I like about the refactoring and splitting into two components is that we don't have to define all the various handlers and other computation for the unmodelable case where we don't use any of them.
Note that right now I don't think we can tell between a method modeled by CodeQL or another extension pack. I'd like to make that more clear but I think it would be better as a separate PR. Therefore the message right now has to cover both cases. Suggestions on the wording of the message are very welcome.
Also note, I've made a separate issue for making the checkboxes work and match the designs. So ignore those for now.
Checklist
ready-for-doc-reviewlabel there.