Skip to content

Bump CLI Version to v2.14.0 for integration tests#2607

Merged
aeisenberg merged 1 commit intomainfrom
github-action/bump-cli
Jul 13, 2023
Merged

Bump CLI Version to v2.14.0 for integration tests#2607
aeisenberg merged 1 commit intomainfrom
github-action/bump-cli

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Bumps CLI version from v2.13.5 to v2.14.0

Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably drop support for 2.7.x

@cklin cklin marked this pull request as ready for review July 13, 2023 20:30
@cklin cklin requested a review from a team as a code owner July 13, 2023 20:30
@aeisenberg
Copy link
Copy Markdown
Contributor

Looks like all of the CLI tests are failing in the same way. This could be a legitimate problem.

@cklin
Copy link
Copy Markdown
Contributor

cklin commented Jul 13, 2023

Looks like all of the CLI tests are failing in the same way. This could be a legitimate problem.

FAIL test/vscode-tests/cli-integration/queries.test.ts (79.795 s)
  Queries
    extension packs (localQueries)
      ✓ should run a query that has an extension without looking for extensions in the workspace (19708 ms)
      ✓ should run a query that has an extension and look for extensions in the workspace (2675 ms)
    extension packs (debug)
      ✓ should run a query that has an extension without looking for extensions in the workspace (5547 ms)
      ✓ should run a query that has an extension and look for extensions in the workspace (4992 ms)
    running queries (localQueries)
      ✓ should run a query (1977 ms)
      ✓ should restart the database and run a query (5866 ms)
    running queries (debug)
      ✓ should run a query (4607 ms)
      ✓ should restart the database and run a query (7538 ms)
    quick query
      ✕ should create a quick query (1276 ms)
      ✓ should avoid creating a quick query (3394 ms)

  ● Queries › quick query › should create a quick query

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

      265 |
      266 |       // should have created the quick query file and query pack file
    > 267 |       expect(pathExistsSync(qlFile)).toBe(true);
          |                                      ^
      268 |       expect(pathExistsSync(qlpackFile)).toBe(true);
      269 |
      270 |       const qlpackContents: any = await load(readFileSync(qlpackFile, "utf8"));

      at Object.<anonymous> (queries.test.ts:267:38)

@aeisenberg
Copy link
Copy Markdown
Contributor

Wait...there are two problems here. First is that codeql/mad was internal. I just changed it to public.

@aeisenberg
Copy link
Copy Markdown
Contributor

@aeisenberg
Copy link
Copy Markdown
Contributor

It's worth re-running the failures since they may all be related to not being able to install codeql/mad.

@aeisenberg
Copy link
Copy Markdown
Contributor

Looks like the problem was with mad.

@aeisenberg aeisenberg merged commit 39465d9 into main Jul 13, 2023
@aeisenberg aeisenberg deleted the github-action/bump-cli branch July 13, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants