Skip to content

Change the data extension's webview icon#2608

Merged
shati-patel merged 2 commits intomainfrom
shati-patel/editor-tab
Jul 14, 2023
Merged

Change the data extension's webview icon#2608
shati-patel merged 2 commits intomainfrom
shati-patel/editor-tab

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

Sets a custom icon for the data extension webview. Annoyingly, it doesn't seem possible to use a built-in VS Code "theme icon" or "codicon", so I had to save the icon to disk.

Dark Light
image image

Checklist

N/A (internal only 🧶)

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel marked this pull request as ready for review July 14, 2023 14:34
@shati-patel shati-patel requested review from a team as code owners July 14, 2023 14:34
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 🎨

Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@shati-patel shati-patel enabled auto-merge (squash) July 14, 2023 15:13
@shati-patel shati-patel merged commit 5631d33 into main Jul 14, 2023
@shati-patel shati-patel deleted the shati-patel/editor-tab branch July 14, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants