Move components for rendering locations to a separate file#2614
Merged
robertbrignull merged 11 commits intomainfrom Jul 18, 2023
Merged
Move components for rendering locations to a separate file#2614robertbrignull merged 11 commits intomainfrom
robertbrignull merged 11 commits intomainfrom
Conversation
koesie10
reviewed
Jul 17, 2023
Member
koesie10
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up! I believe most of my comments are about things that were already there in the old components, but can be improved as part of this cleanup as well.
koesie10
reviewed
Jul 18, 2023
Member
koesie10
left a comment
There was a problem hiding this comment.
Thanks for making those changes!
koesie10
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR achieves two goals:
renderLocationto actual react components that can have things like state and hooks.This causes a slight increase in line count because we need to pass around more state as props rather than inheriting it from the environment. Arguably this is a benefit to long term readability and maintainability of the components by avoiding implicit coupling.
This PR is a potential stepping stone towards breaking up and modernising
AlertTable. But this PR is not essential. I'm open to not grouping these functions intolocations.tsxif this grouping of components doesn't make the code easier to understand.Checklist
ready-for-doc-reviewlabel there.