Skip to content

Implement "model dependency" button in application mode#2623

Merged
robertbrignull merged 3 commits intomainfrom
robertbrignull/data-model-dependency
Jul 21, 2023
Merged

Implement "model dependency" button in application mode#2623
robertbrignull merged 3 commits intomainfrom
robertbrignull/data-model-dependency

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

This PR adds the implementation for the "model dependency" button. This prompts the user for a repository name, then downloads that repository and opens a new data extensions window in framework mode.

This shares a bunch of implementation with the "model from source" button because they both prompt the user to download a new database. I think both of these will continue to share implementation, so any improvements we make will apply to both.

I have encountered problems when the new databases causes the workspace to transition from single-root to multi-root. I have some ideas for things we can do about this, and these might help with "model from source" as well if that shares the same issue. However I'm thinking about raising those changes as separate PRs.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested review from a team as code owners July 20, 2023 08:13
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks sensible and we've tested it on my (Windows) machine too 🪟

Regarding the single-folder workspace bug: this is a more general problem, so I don't think it's worth addressing in this PR. We'll probably have to do more work to get the Data Extensions Editor working in that case (if we even want to support single-folder workspaces fully).

Also: as discussed offline, we weren't sure if/how to test this 🧪 Seems fine to merge as-is, and we can think about that later 🤔

@robertbrignull robertbrignull merged commit 778f839 into main Jul 21, 2023
@robertbrignull robertbrignull deleted the robertbrignull/data-model-dependency branch July 21, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants