Implement "model dependency" button in application mode#2623
Merged
robertbrignull merged 3 commits intomainfrom Jul 21, 2023
Merged
Implement "model dependency" button in application mode#2623robertbrignull merged 3 commits intomainfrom
robertbrignull merged 3 commits intomainfrom
Conversation
shati-patel
approved these changes
Jul 21, 2023
Contributor
There was a problem hiding this comment.
Code looks sensible and we've tested it on my (Windows) machine too 🪟
Regarding the single-folder workspace bug: this is a more general problem, so I don't think it's worth addressing in this PR. We'll probably have to do more work to get the Data Extensions Editor working in that case (if we even want to support single-folder workspaces fully).
Also: as discussed offline, we weren't sure if/how to test this 🧪 Seems fine to merge as-is, and we can think about that later 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the implementation for the "model dependency" button. This prompts the user for a repository name, then downloads that repository and opens a new data extensions window in framework mode.
This shares a bunch of implementation with the "model from source" button because they both prompt the user to download a new database. I think both of these will continue to share implementation, so any improvements we make will apply to both.
I have encountered problems when the new databases causes the workspace to transition from single-root to multi-root. I have some ideas for things we can do about this, and these might help with "model from source" as well if that shares the same issue. However I'm thinking about raising those changes as separate PRs.
Checklist
ready-for-doc-reviewlabel there.