Remove or fix dead code / unused exports#2632
Merged
robertbrignull merged 13 commits intomainfrom Jul 24, 2023
Merged
Conversation
3 tasks
charisk
approved these changes
Jul 24, 2023
Contributor
charisk
left a comment
There was a problem hiding this comment.
Thanks for cleaning up! 🧹
7f36372 to
729471d
Compare
Contributor
Author
|
It seems that |
729471d to
8e8e0fa
Compare
Contributor
Author
|
Annoying I rebased on the wrong base commit originally, but https://github.com/github/vscode-codeql/compare/7f363723f9c0e4c2d4703172d2f5497a00a6e1b3..8e8e0faa9e4e0284d0ea5ec2be9dfbb06f8515ca shows the change from where this PR was at before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2631 for the dead code CI check. This PR is the result of going through the codebase fixing all of the cases found by that check. Where there is code deleted I've done each item as a separate commit, and then at the end I've done one commit for all the cases of things that were unnecessarily-exported but still used within their file.
I haven't tested all features yet to make sure everything still works, but from what I could tell as I was going through things there's nothing that's likely to not be caught at compile time, so I'm fairly confident this is all ok so long as it compiles.
Checklist
ready-for-doc-reviewlabel there.