Skip to content

Add new data extensions header UI elements#2638

Merged
robertbrignull merged 3 commits intomainfrom
robertbrignull/data_new_header
Jul 26, 2023
Merged

Add new data extensions header UI elements#2638
robertbrignull merged 3 commits intomainfrom
robertbrignull/data_new_header

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

Updates the rest of the data extensions editor header to match the new designs.

  • Application mode
    Screenshot 2023-07-25 at 15 03 01
  • Framework mode
    Screenshot 2023-07-25 at 15 03 11

Now there are a few deviations from the original designs here:

  • We're not going to do the "Hide open source dependencies" checkbox for now.
  • We can't show "dependency_name@version" in framework mode because we don't know that information.
  • We need to keep the "switch mode" button, although its text has been updated.
  • The "open database" button shows the database source archive in the VS Code file explorer.
  • I've kept the "open extension pack" button so there's still a way to locate those files.
    • Note that we may change its text in the future to remove the reference of "extension pack".
    • We could consider putting this on each individual section instead, so there's a way of linking to each model file directly.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested review from a team as code owners July 25, 2023 14:08
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread extensions/ql-vscode/src/view/data-extensions-editor/DataExtensionsEditor.tsx Outdated
@robertbrignull robertbrignull enabled auto-merge July 26, 2023 08:52
@robertbrignull robertbrignull merged commit 41f5beb into main Jul 26, 2023
@robertbrignull robertbrignull deleted the robertbrignull/data_new_header branch July 26, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants