Skip to content

legacy-query.test.ts: skip if CLI supports new query server#2649

Merged
cklin merged 1 commit intomainfrom
cklin/remove-legacy-query-server-test
Jul 27, 2023
Merged

legacy-query.test.ts: skip if CLI supports new query server#2649
cklin merged 1 commit intomainfrom
cklin/remove-legacy-query-server-test

Conversation

@cklin
Copy link
Copy Markdown
Contributor

@cklin cklin commented Jul 27, 2023

This PR modifies legacy-query.test.ts, which tests integration with the legacy query server in the CodeQL CLI (i.e., codeql execute query-server), to run only for CLI versions that are too old to support the new query server (i.e., codeql execute query-server2). The vscode extension automatically selects the new query server whenever possible, so it should be sufficient to test legacy query server integration only with old CLI versions.

See back-linked internal issue for additional context.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@cklin cklin force-pushed the cklin/remove-legacy-query-server-test branch from a4f6008 to a34b304 Compare July 27, 2023 15:14
@cklin cklin changed the title Delete legacy-query.test.ts legacy-query.test.ts: skip if CLI supports new query server Jul 27, 2023
Comment thread extensions/ql-vscode/test/vscode-tests/cli-integration/legacy-query.test.ts Outdated
@cklin cklin force-pushed the cklin/remove-legacy-query-server-test branch from a34b304 to 72fa1c5 Compare July 27, 2023 16:10
@cklin cklin marked this pull request as ready for review July 27, 2023 16:18
@cklin cklin requested a review from a team as a code owner July 27, 2023 16:18
@cklin cklin merged commit c1107d7 into main Jul 27, 2023
@cklin cklin deleted the cklin/remove-legacy-query-server-test branch July 27, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants