legacy-query.test.ts: skip if CLI supports new query server#2649
Merged
Conversation
a4f6008 to
a34b304
Compare
aeisenberg
reviewed
Jul 27, 2023
a34b304 to
72fa1c5
Compare
aeisenberg
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies
legacy-query.test.ts, which tests integration with the legacy query server in the CodeQL CLI (i.e.,codeql execute query-server), to run only for CLI versions that are too old to support the new query server (i.e.,codeql execute query-server2). The vscode extension automatically selects the new query server whenever possible, so it should be sufficient to test legacy query server integration only with old CLI versions.See back-linked internal issue for additional context.
Checklist
ready-for-doc-reviewlabel there.