Merged
Conversation
Contributor
|
Looks good, thank you! Would it be useful to mention this in the testing.md file? |
koesie10
reviewed
Jul 31, 2023
Member
koesie10
left a comment
There was a problem hiding this comment.
Sometimes, it seems like there are also .vscode-test directories in subdirectories (like in test/vscode-tests/no-workspace). Could we also remove those automatically when running this?
4fad91a to
5107086
Compare
Contributor
Author
|
I've switched it to use I haven't tested it but the info I've seen says these args should work on linux as well as mac, and therefore hopefully windows too in a gitbash or WSL shell. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the tests can fail to run and cleaning the
.vscode-testdir is necessary to fix them. This PR adds this as a npm script so it's easier to remember that this option exists and what to do.Is using
rmand this path ok? Will this be ok for all operating systems?Alternative suggestions for naming are also welcome.
Checklist
ready-for-doc-reviewlabel there.