Skip to content

Remove submodules dependency from data extension editor#2658

Merged
norascheuch merged 13 commits intomainfrom
nora-koen/data-extensions-editor-without-ql-submodule
Aug 2, 2023
Merged

Remove submodules dependency from data extension editor#2658
norascheuch merged 13 commits intomainfrom
nora-koen/data-extensions-editor-without-ql-submodule

Conversation

@norascheuch
Copy link
Copy Markdown
Contributor

Instead of creating a new temporary folder with dependency files every time we fetch the external api usage, we do this only once now during startup of the editor. This is also the time when we now install pack dependencies and thus remove dependency on submodules.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@norascheuch norascheuch requested review from a team as code owners July 31, 2023 11:49
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked through the code but haven't tested it yet. I'll give it a go a bit later on. I have a couple of small suggestions to make the code easier to read, but overall the change looks good to me.

@norascheuch norascheuch force-pushed the nora-koen/data-extensions-editor-without-ql-submodule branch 2 times, most recently from b46b8e7 to e912e6f Compare August 1, 2023 12:39
@norascheuch norascheuch force-pushed the nora-koen/data-extensions-editor-without-ql-submodule branch from e912e6f to 5f48921 Compare August 1, 2023 12:39
@robertbrignull
Copy link
Copy Markdown
Contributor

I've tested it out, both in a codespace and locally in a repo without the QL submodule. It worked in both cases! 🎉 🌮

Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments which you could address or leave, but generally I think this PR is ok and it works well for me when testing it.

@norascheuch norascheuch merged commit 80ae9a4 into main Aug 2, 2023
@norascheuch norascheuch deleted the nora-koen/data-extensions-editor-without-ql-submodule branch August 2, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants