Remove submodules dependency from data extension editor#2658
Merged
norascheuch merged 13 commits intomainfrom Aug 2, 2023
Merged
Remove submodules dependency from data extension editor#2658norascheuch merged 13 commits intomainfrom
norascheuch merged 13 commits intomainfrom
Conversation
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
I've looked through the code but haven't tested it yet. I'll give it a go a bit later on. I have a couple of small suggestions to make the code easier to read, but overall the change looks good to me.
extensions/ql-vscode/src/data-extensions-editor/external-api-usage-query.ts
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-module.ts
Outdated
Show resolved
Hide resolved
b46b8e7 to
e912e6f
Compare
e912e6f to
5f48921
Compare
Contributor
|
I've tested it out, both in a codespace and locally in a repo without the QL submodule. It worked in both cases! 🎉 🌮 |
robertbrignull
approved these changes
Aug 2, 2023
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
A couple of comments which you could address or leave, but generally I think this PR is ok and it works well for me when testing it.
extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-module.ts
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/data-extensions-editor/external-api-usage-query.ts
Show resolved
Hide resolved
robertbrignull
approved these changes
Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of creating a new temporary folder with dependency files every time we fetch the external api usage, we do this only once now during startup of the editor. This is also the time when we now install pack dependencies and thus remove dependency on submodules.
Checklist
ready-for-doc-reviewlabel there.