Delete untoggleProblemsView as it is unused#2665
Merged
robertbrignull merged 1 commit intomainfrom Aug 3, 2023
Merged
Conversation
As far as I can tell it's been unused as far as back as #602 when it was introduced. It seems just to be an error in that PR.
robertbrignull
deleted the
robertbrignull/ResultTables-untoggleProblemsView
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was introduced in #602 and as far as I can tell it's always been unused. It seems just to be an error in that PR and the actual setting of state is done in
handleCheckboxChanged.Our deadcode detection seems to not be working for public methods on components like this.
Checklist
ready-for-doc-reviewlabel there.