Merged
Conversation
starcke
approved these changes
Aug 7, 2023
Contributor
starcke
left a comment
There was a problem hiding this comment.
Looks great. I wanted to do that refactor, but got sidetracked with the actual implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very small refactor that splits the code paths between automodel v1 and automodel v2 further up. I got the original
generateModeledMethodsFromLlmmethod and copy pasted it, named one of the functionsgenerateModeledMethodsFromLlmV1and the othergenerateModeledMethodsFromLlmV2, then simply cleaned up the code to only to do v1 stuff in onegenerateModeledMethodsFromLlmV1and v2 stuff ingenerateModeledMethodsFromLlmV2. I haven't any other significant changes.The two code paths are about to diverge further, so having separate functions will make it easier to make changes to them independently. We could also jut get rid of V1 for now, but that seemed like a bigger change to take on right now.
Checklist
N/A:
ready-for-doc-reviewlabel there.