Skip to content

Move automodel version split further up#2676

Merged
charisk merged 1 commit intomainfrom
charisk/minor-automodel-refactor
Aug 7, 2023
Merged

Move automodel version split further up#2676
charisk merged 1 commit intomainfrom
charisk/minor-automodel-refactor

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Aug 7, 2023

This is a very small refactor that splits the code paths between automodel v1 and automodel v2 further up. I got the original generateModeledMethodsFromLlm method and copy pasted it, named one of the functions generateModeledMethodsFromLlmV1 and the other generateModeledMethodsFromLlmV2, then simply cleaned up the code to only to do v1 stuff in one generateModeledMethodsFromLlmV1 and v2 stuff in generateModeledMethodsFromLlmV2. I haven't any other significant changes.

The two code paths are about to diverge further, so having separate functions will make it easier to make changes to them independently. We could also jut get rid of V1 for now, but that seemed like a bigger change to take on right now.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from starcke August 7, 2023 11:26
@charisk charisk requested a review from a team as a code owner August 7, 2023 11:26
Copy link
Copy Markdown
Contributor

@starcke starcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I wanted to do that refactor, but got sidetracked with the actual implementation.

@charisk charisk enabled auto-merge (squash) August 7, 2023 11:39
@charisk charisk merged commit f1204ce into main Aug 7, 2023
@charisk charisk deleted the charisk/minor-automodel-refactor branch August 7, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants