Skip to content

Populate details panel with external API usages#2678

Merged
robertbrignull merged 2 commits intomainfrom
robert-nora/model-details-data
Aug 8, 2023
Merged

Populate details panel with external API usages#2678
robertbrignull merged 2 commits intomainfrom
robert-nora/model-details-data

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

This PR adds ModelDetailsPanel and ModelDetailsDataProvider, and populates the tree view with data whenever new external API usages are calculated.

Screenshot 2023-08-08 at 10 56 00

This isn't perfect, but everything is hidden behind a feature flag so I think this is a suitable step in the right direction. There are still lots of changes to make, which we'll do in future PRs. For example:

  • Handling when there are multiple data extensions editor windows open at once.
  • Making sure data is always updated when new external API usages are calculated.
  • Styling of the details panel, with icons and better labels.
  • Jumping to definition when clicking an item.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team as a code owner August 8, 2023 10:07
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@robertbrignull robertbrignull merged commit daf389a into main Aug 8, 2023
@robertbrignull robertbrignull deleted the robert-nora/model-details-data branch August 8, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants