Merged
Conversation
starcke
approved these changes
Aug 9, 2023
| ) => Promise<void>, | ||
| ) {} | ||
|
|
||
| public async startModeling( |
Contributor
There was a problem hiding this comment.
Is this method to prepare for the future, because it doesnt seem to do much other than just call the other method?
Contributor
Author
There was a problem hiding this comment.
Yep, exactly. It'll be doing a bit more later on.
| import { DatabaseItem } from "../databases/local-databases"; | ||
| import { Mode } from "./shared/mode"; | ||
|
|
||
| export class AutoModeler { |
Contributor
There was a problem hiding this comment.
Should we add some comments to the methods in here?
Contributor
Author
There was a problem hiding this comment.
Sure. Did you have anything specific in mind that you wanted commented?
Contributor
Author
There was a problem hiding this comment.
I might just do that in a separate PR when there's a bit more beef to it. But please let me know if you'd like anything specific commented :)
Contributor
There was a problem hiding this comment.
Maybe what some of the parameters should contain? We can also do it in a followup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved logic out of the data extensions editor view and into a new
AutoModelerclass.This will make it easier to introduce batching and cancellation.
There are no material changes in this PR, code has mostly been copy pasted with minor edits.
Checklist
N/A:
ready-for-doc-reviewlabel there.