Skip to content

Minor auto-model polish#2689

Merged
charisk merged 1 commit intomainfrom
charisk/automodel-polish
Aug 10, 2023
Merged

Minor auto-model polish#2689
charisk merged 1 commit intomainfrom
charisk/automodel-polish

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Aug 10, 2023

Two changes:

  • Adds some code comments around the automodeler
  • Removes the various progress notifications since these are visible in the view. We still have the junky progress notifications around query running but I'm unsure how to fix that and think it's okay for now.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from starcke August 10, 2023 11:06
@charisk charisk requested a review from a team as a code owner August 10, 2023 11:06
Copy link
Copy Markdown
Contributor

@starcke starcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that is great - indeed all those progress messages were confusing me.

@charisk charisk merged commit b8ba32f into main Aug 10, 2023
@charisk charisk deleted the charisk/automodel-polish branch August 10, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants