Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the model always returned
sqlsinks. I think that is because it actually returned kinds we didnt understand. This is due to the kinds changing since we implemented the editor.I have gone and updated the ones we were using and added all the shared ones from https://github.com/github/codeql/blob/main/shared/mad/codeql/mad/ModelValidation.qll.
This should now include all the ones the LLM will return. Longer term we might want to get the valid kinds with a query and potentially also allow for free-text kinds.
Checklist
ready-for-doc-reviewlabel there.