Skip to content

Add more sink and source kinds.#2691

Merged
starcke merged 1 commit intomainfrom
starcke/more-kinds
Aug 11, 2023
Merged

Add more sink and source kinds.#2691
starcke merged 1 commit intomainfrom
starcke/more-kinds

Conversation

@starcke
Copy link
Copy Markdown
Contributor

@starcke starcke commented Aug 10, 2023

I noticed that the model always returned sql sinks. I think that is because it actually returned kinds we didnt understand. This is due to the kinds changing since we implemented the editor.

I have gone and updated the ones we were using and added all the shared ones from https://github.com/github/codeql/blob/main/shared/mad/codeql/mad/ModelValidation.qll.

This should now include all the ones the LLM will return. Longer term we might want to get the valid kinds with a query and potentially also allow for free-text kinds.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@starcke starcke marked this pull request as ready for review August 10, 2023 13:47
@starcke starcke requested a review from a team as a code owner August 10, 2023 13:47
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we close #2415 after merging this?

@starcke starcke merged commit b3e81ff into main Aug 11, 2023
@starcke starcke deleted the starcke/more-kinds branch August 11, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants