Only show the details view when a data extensions editor is open#2709
Merged
robertbrignull merged 1 commit intomainfrom Aug 16, 2023
Merged
Only show the details view when a data extensions editor is open#2709robertbrignull merged 1 commit intomainfrom
robertbrignull merged 1 commit intomainfrom
Conversation
robertbrignull
force-pushed
the
robertbrignull/details-visible
branch
from
b56855e to
3a38579
Compare
Base automatically changed from
robertbrignull/details-multiple-editors
to
main
August 16, 2023 11:47
robertbrignull
force-pushed
the
robertbrignull/details-visible
branch
from
3a38579 to
fed9870
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements only showing the details view when at least one data extensions editor is open. When a new editor is opened we set the
codeql.dataExtensionsEditorOpencontext key to true, and when an editor is closed we check to see if there are any others remaining and set the context value accordingly.In my local testing it's working pretty well.
Checklist
ready-for-doc-reviewlabel there.