Skip to content

Rename files in src/view/results to match their components #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbrignull merged 4 commits into from
Aug 17, 2023
Merged

Rename files in src/view/results to match their components #2716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0acd06f
Rename alert-table.tsx => AlertTable.tsx
robertbrignull Aug 16, 2023
67b138f
Rename graph.tsx => Graph.tsx
robertbrignull Aug 16, 2023
ed36fb7
Rename raw-results-table.tsx => RawTable.tsx
robertbrignull Aug 16, 2023
3164c3f
Rename results.tsx => ResultsApp.tsx
robertbrignull Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...l-vscode/src/view/results/alert-table.tsx → ...ql-vscode/src/view/results/AlertTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
selectableZebraStripe,
jumpToLocation,
} from "./result-table-utils";
import { onNavigation } from "./results";
import { onNavigation } from "./ResultsApp";
import {
InterpretedResultSet,
NavigateMsg,
Expand Down
0 ...ions/ql-vscode/src/view/results/graph.tsx → ...ions/ql-vscode/src/view/results/Graph.tsx
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...de/src/view/results/raw-results-table.tsx → ...s/ql-vscode/src/view/results/RawTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
import RawTableHeader from "./RawTableHeader";
import RawTableRow from "./RawTableRow";
import { ResultRow } from "../../common/bqrs-cli-types";
import { onNavigation } from "./results";
import { onNavigation } from "./ResultsApp";
import { tryGetResolvableLocation } from "../../common/bqrs-utils";
import { ScrollIntoViewHelper } from "./scroll-into-view-helper";
import { sendTelemetry } from "../common/telemetry";
Expand Down
6 changes: 3 additions & 3 deletions extensions/ql-vscode/src/view/results/ResultTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as React from "react";
import { AlertTable } from "./alert-table";
import { Graph } from "./graph";
import { RawTable } from "./raw-results-table";
import { AlertTable } from "./AlertTable";
import { Graph } from "./Graph";
import { RawTable } from "./RawTable";
import { ResultTableProps } from "./result-table-utils";

export function ResultTable(props: ResultTableProps) {
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/results/ResultTables.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export function ResultTables(props: ResultTablesProps) {
[handleMessage],
);

// TODO: Duplicated from results.tsx consider a way to
// TODO: Duplicated from ResultsApp.tsx consider a way to
// avoid this duplication
useEffect(() => {
window.addEventListener("message", vscodeMessageHandler);
Expand Down
2 changes: 1 addition & 1 deletion ...ns/ql-vscode/src/view/results/results.tsx → ...ql-vscode/src/view/results/ResultsApp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import "./resultsView.css";
import { useCallback, useEffect } from "react";

/**
* results.tsx
* ResultsApp.tsx
* -----------
*
* Displaying query results.
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/results/__tests__/results.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from "react";
import { render as reactRender, screen } from "@testing-library/react";
import { ResultsApp } from "../results";
import { ResultsApp } from "../ResultsApp";
import {
Interpretation,
IntoResultsViewMsg,
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/results/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from "react";
import { WebviewDefinition } from "../webview-definition";
import { ResultsApp } from "./results";
import { ResultsApp } from "./ResultsApp";

const definition: WebviewDefinition = {
component: <ResultsApp />,
Expand Down