Skip to content

Upgrade Storybook#2718

Merged
koesie10 merged 1 commit intomainfrom
koesie10/upgrade-storybook
Aug 17, 2023
Merged

Upgrade Storybook#2718
koesie10 merged 1 commit intomainfrom
koesie10/upgrade-storybook

Conversation

@koesie10
Copy link
Copy Markdown
Member

On my local machine, I wasn't able to run Storybook anymore due to some errors. After upgrading Storybook, it did start again.

This is the command I ran to upgrade Storybook:

npm upgrade @storybook/addon-actions @storybook/addon-essentials @storybook/addon-interactions @storybook/addon-links  @storybook/components @storybook/csf @storybook/manager-api @storybook/react @storybook/react-webpack5 @storybook/theming storybook

There should be no other changes.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review August 16, 2023 14:51
@koesie10 koesie10 requested a review from a team as a code owner August 16, 2023 14:51
@koesie10 koesie10 requested a review from a team August 16, 2023 14:51
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to replicate the failure as it works for me on main as well as on this branch. But upgrading the storybook dependencies sounds fine to me regardless.

Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me too 🎉

@koesie10 koesie10 enabled auto-merge August 17, 2023 07:48
@koesie10 koesie10 merged commit a86a373 into main Aug 17, 2023
@koesie10 koesie10 deleted the koesie10/upgrade-storybook branch August 17, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants