Merged
Conversation
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
Ah, I didn't know we had TestButton. That's cool, and I agree that's the right component to use here.
I think I've tested all the UI elements that have changed, and I found one that was a bit different than it was before, but everything else seems good.
charisk
reviewed
Aug 17, 2023
Contributor
|
Fixed the merge conflicts with #2726 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces all
<a href="#" onClick={...}>...</a>by<button>element styled as a link using theTextButtoncomponent. This improves accessibility. There should be no changes in behavior or UI.Checklist
ready-for-doc-reviewlabel there.