Add more types and documentation to protocol file #272
Merged
jcreedcmu merged 1 commit intogithub:masterfrom Mar 10, 2020
Merged
Add more types and documentation to protocol file #272jcreedcmu merged 1 commit intogithub:masterfrom
jcreedcmu merged 1 commit intogithub:masterfrom
Conversation
jcreedcmu
changed the title
Reduce the chances that someone reading this file forgets the intent of the extensible 'enum' namespaces by redundantly putting it loudly at the beginning. Add some eponymous type aliases for these 'enum' types so that code can refer to them.
jcreedcmu
force-pushed
the
jcreed/enums-revert
branch
from
795cd90 to
c15b1cd
Compare
aeisenberg
approved these changes
Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.