Split AlertTable into smaller components#2732
Conversation
…Click in AlertTablePathRow
…Click in AlertTableResultRow
charisk
left a comment
There was a problem hiding this comment.
LGTM in general although I can't promise I've gone through every line and character change since there is a fair bit of code moving around. I think there are a couple of cases where we're using useMemo when we should be using useCallback (unless I misread the code) but otherwise LGTM!
Thanks for making this better gradually - it's great to see the individual components now.
|
Thank you @charisk for the review. For the |
Refactors the rendering in
AlertTable. Previous it was multiple nestedforeachloops adding components to arowsarray from multiple places, including the rendering of zero results or truncated results. As of this PR it's a series of hierarchical components.Each small change is done as a separate commit, so theoretically you should be able to follow along with them. Or it may be easier to review the end result on its own if that's what you prefer.
I've tried to test manually and as far as I can tell, everything looks and behaves exactly the same as before 🎉
Checklist
ready-for-doc-reviewlabel there.