Merged
Conversation
charisk
approved these changes
Aug 22, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Looking great! I really like how this is shaping up. Just some minor comments.
| import { redactableError } from "../common/errors"; | ||
| import { basename } from "path"; | ||
|
|
||
| type RunQueriesOptions = { |
Contributor
There was a problem hiding this comment.
(Minor) Should this be RunQueryOptions?
| }; | ||
| } | ||
|
|
||
| async function resolveAutomodelQueries( |
Contributor
There was a problem hiding this comment.
Since we only expect 1 query and throw if we don't resolve exactly 1 query, I think this function should be called resolveAutomodelQuery
aeisenberg
reviewed
Aug 22, 2023
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Nice. Just a minor comment.
| ); | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars -- We only need the actual SARIF data, not the extra fields added by SarifInterpretationData | ||
| const { t, sortState, ...sarif } = await interpretResultsSarif( |
Contributor
There was a problem hiding this comment.
Minor: Looks like you can do this:
Suggested change
| const { t, sortState, ...sarif } = await interpretResultsSarif( | |
| const { ...sarif } = await interpretResultsSarif( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This generalizes the automodel queries so that they rely on shared resolution and run methods.
Checklist
ready-for-doc-reviewlabel there.