Skip to content

Convert AlertTable to a function component#2737

Merged
robertbrignull merged 7 commits intomainfrom
robertbrignull/AlertTable-functional
Aug 22, 2023
Merged

Convert AlertTable to a function component#2737
robertbrignull merged 7 commits intomainfrom
robertbrignull/AlertTable-functional

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

Final PR to convert AlertTable into a function component. See each individual commit for the individual steps.

Uses the same solution for the ScrollIntoViewHelper as we did in RawTable. And I also have a further idea for how to make it more react-y that I'll open at a later date.

From my manual testing it appears to look and behave exactly as it did before.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team August 22, 2023 13:31
@robertbrignull robertbrignull requested a review from a team as a code owner August 22, 2023 13:31
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@robertbrignull robertbrignull merged commit d777427 into main Aug 22, 2023
@robertbrignull robertbrignull deleted the robertbrignull/AlertTable-functional branch August 22, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants