Skip to content

Rename WebviewView to WebviewKind#2739

Merged
charisk merged 1 commit intomainfrom
charisk/rename-webview-view
Aug 23, 2023
Merged

Rename WebviewView to WebviewKind#2739
charisk merged 1 commit intomainfrom
charisk/rename-webview-view

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Aug 23, 2023

The term WebviewView has a specific meaning in VS Code extensions (see docs), so this PR renames our own WebviewView to avoid confusion.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner August 23, 2023 09:58
shati-patel
shati-patel approved these changes Aug 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@charisk charisk merged commit 0352629 into main Aug 23, 2023
@charisk charisk deleted the charisk/rename-webview-view branch August 23, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @shati-patel