Skip to content

Variant analysis: Always read BQRS results file if it's available#2741

Merged
shati-patel merged 1 commit intomainfrom
shati-patel/read-bqrs
Aug 24, 2023
Merged

Variant analysis: Always read BQRS results file if it's available#2741
shati-patel merged 1 commit intomainfrom
shati-patel/read-bqrs

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

Once github/codeql-variant-analysis-action#854 is merged, a succesful variant analysis run will always have the result.bqrs file available.

Instead of choosing to read interpreted results or raw results, we should support having both. (This is so that users will be able to toggle between raw and interpreted results in the results view.)

Checklist

N/A—no user impact yet 🦁

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel marked this pull request as ready for review August 23, 2023 14:58
@shati-patel shati-patel requested a review from a team as a code owner August 23, 2023 14:58
@shati-patel shati-patel force-pushed the shati-patel/read-bqrs branch from 70850f6 to 54bc4d9 Compare August 24, 2023 09:19
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shati-patel shati-patel merged commit 2ffb789 into main Aug 24, 2023
@shati-patel shati-patel deleted the shati-patel/read-bqrs branch August 24, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants