Update pnpm, rush and add sinon as a dependency#275
Conversation
aeisenberg
force-pushed
the
update-pnpm
branch
4 times, most recently
from
e6c0b32 to
2390c06
Compare
|
Seems like I can't update pnpm without also updating rush and vice versa. However, there's a problem once I update both. The version of |
|
It looks like this dependency syntax is specific to pnpm but it is not being recognized by rush. |
| "chai": "^4.2.0", | ||
| "css-loader": "~3.1.0", | ||
| "glob": "^7.1.4", | ||
| "glob": "7.0.0", |
There was a problem hiding this comment.
is this downgrade necessary?
There was a problem hiding this comment.
oops. Things were really broken for a while and I was trying a bunch of things. I didn't mean to commit that change.
| "lib/semmle-io/tsconfig.json": "d2df609ec96013b8b05cec7edc86e73c3e473a55", | ||
| "lib/semmle-io/.rush/temp/package-deps_build.json": "610cbc3c43aaf3da66a78f33ec0844c7a6fd25a8" | ||
| }, | ||
| "arguments": "gulp " |
There was a problem hiding this comment.
is this trailing space on purpose?
There was a problem hiding this comment.
Maybe it's autogenerated and meant to be that way, not sure...
There was a problem hiding this comment.
Not sure if it's necessary. Though, since it's autogenerated, I'd rather not change it.
| "lib/semmle-vscode-utils/tsconfig.json": "d2df609ec96013b8b05cec7edc86e73c3e473a55", | ||
| "lib/semmle-vscode-utils/.rush/temp/package-deps_build.json": "cf773384acc45ec16dab6eed31cb84b76862389d" | ||
| }, | ||
| "arguments": "gulp " |
There was a problem hiding this comment.
same question about trailing space here
Note that pnpm no longer uses shrinkwrap.yaml. I'm not entirely happy with this solution because it makes a change to the rush.ts build script in order to handle peer dependencies coming from pnpm. Seems to work, though.
2 participants
Note that pnpm no longer uses shrinkwrap.yaml. Instead it's using
pnpm-lock.yaml.