Skip to content

Remove codeQL.dataExtensions.frameworkMode setting#2753

Merged
charisk merged 1 commit intomainfrom
charisk/remove-framework-mode-ff
Aug 25, 2023
Merged

Remove codeQL.dataExtensions.frameworkMode setting#2753
charisk merged 1 commit intomainfrom
charisk/remove-framework-mode-ff

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Aug 25, 2023

Remove the feature flag and always allow framework mode to be used.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from starcke August 25, 2023 11:09
@charisk charisk requested review from a team as code owners August 25, 2023 11:09
starcke
starcke approved these changes Aug 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@starcke starcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@charisk charisk enabled auto-merge (squash) August 25, 2023 11:21
@charisk charisk merged commit 3c7e1fc into main Aug 25, 2023
@charisk charisk deleted the charisk/remove-framework-mode-ff branch August 25, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starcke starcke starcke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @starcke