Skip to content

Starcke/rename files#2759

Merged
starcke merged 2 commits intomainfrom
starcke/rename-files
Aug 30, 2023
Merged

Starcke/rename files#2759
starcke merged 2 commits intomainfrom
starcke/rename-files

Conversation

@starcke
Copy link
Copy Markdown
Contributor

@starcke starcke commented Aug 30, 2023

Rename data-extension-editor files to model-editor instead.

I also had to change the WebviewKind otherwise it failed when getting passed a message. Not exactly sure how that works or if there are other places we need to change.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@starcke starcke marked this pull request as ready for review August 30, 2023 12:26
@starcke starcke requested review from a team as code owners August 30, 2023 12:26
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The WebViewKind is used to figure out the locations of files, that's why you had to rename it.

@starcke
Copy link
Copy Markdown
Contributor Author

starcke commented Aug 30, 2023

LGTM! The WebViewKind is used to figure out the locations of files, that's why you had to rename it.

I thought it might, but didnt know where that happened, and the error was a bit confusing (it complained about an assertNever that apparently got hit).

@starcke starcke merged commit 7fbb128 into main Aug 30, 2023
@starcke starcke deleted the starcke/rename-files branch August 30, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants