Skip to content

Starcke/rename vars#2763

Merged
starcke merged 4 commits intomainfrom
starcke/rename-vars
Aug 31, 2023
Merged

Starcke/rename vars#2763
starcke merged 4 commits intomainfrom
starcke/rename-vars

Conversation

@starcke
Copy link
Copy Markdown
Contributor

@starcke starcke commented Aug 30, 2023

This does a bunch of in-file renames (variables, strings, etc). It doesnt touch the feature-flags yet.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@starcke starcke marked this pull request as ready for review August 31, 2023 06:54
@starcke starcke requested review from a team as code owners August 31, 2023 06:54
charisk
charisk approved these changes Aug 31, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@starcke starcke merged commit e61f619 into main Aug 31, 2023
@starcke starcke deleted the starcke/rename-vars branch August 31, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charisk charisk charisk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@starcke @charisk