Merged
Conversation
6a8509b to
0836307
Compare
robertbrignull
approved these changes
Aug 31, 2023
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
I found one remaining reference in a comment:
But otherwise this looks good to me as a code change.
I've asked one question on the internal issue about whether it's ok to not have a transition period where we support both feature flags.
Contributor
Author
I'll do that in a followup to not drag this one out. I had to run CI quite a few times to get it though yesterday. |
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the feature flags from:
to
Checklist
ready-for-doc-reviewlabel there.