Skip to content

Rename feature flags.#2766

Merged
starcke merged 1 commit intomainfrom
starcke/rename-ff
Sep 1, 2023
Merged

Rename feature flags.#2766
starcke merged 1 commit intomainfrom
starcke/rename-ff

Conversation

@starcke
Copy link
Copy Markdown
Contributor

@starcke starcke commented Aug 31, 2023

This renames the feature flags from:

    "codeQL.dataExtensions.editor": true,
    "codeQL.dataExtensions.llmGeneration": true,
    "codeQL.dataExtensions.disableAutoNameExtensionPack": true,
    "codeQL.dataExtensions.extensionsDirectory": true,

to

    "codeQL.model.editor": true,
    "codeQL.model.llmGeneration": true,
    "codeQL.model.disableAutoNameExtensionPack": true,
    "codeQL.model.extensionsDirectory": true,

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@starcke starcke force-pushed the starcke/rename-ff branch from 6a8509b to 0836307 Compare August 31, 2023 07:46
@starcke starcke marked this pull request as ready for review August 31, 2023 11:26
@starcke starcke requested review from a team as code owners August 31, 2023 11:26
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one remaining reference in a comment:

But otherwise this looks good to me as a code change.

I've asked one question on the internal issue about whether it's ok to not have a transition period where we support both feature flags.

@starcke starcke merged commit a674537 into main Sep 1, 2023
@starcke starcke deleted the starcke/rename-ff branch September 1, 2023 08:35
@starcke
Copy link
Copy Markdown
Contributor Author

starcke commented Sep 1, 2023

I found one remaining reference in a comment

I'll do that in a followup to not drag this one out. I had to run CI quite a few times to get it though yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants