Make the "Create query" location workspace-specific#2769
Merged
shati-patel merged 2 commits intomainfrom Aug 31, 2023
Merged
Conversation
robertbrignull
approved these changes
Aug 31, 2023
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
LGTM
Us I understand it, if a value has already been written the global settings, then we'll continue to use it. But if we write a new value it'll go to workspace settings. So in that way it's compatible with existing data and that's good.
Contributor
Author
That's exactly right! Thanks ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user picks a folder in which to create custom queries (
createQuery.qlPackLocation), that should be saved in workspace settings, rather than global settings by default. See internal linked issue for details! 📦I've also changed
createQuery.autogenerateQlPacksto get written to workspace settings, for consistency. There's no harm either way, but I think we should default to workspace settings, and only write to global settings for "higher-level" settings (such as enabling/disabling telemetry) ⚙Checklist
N/A—this is still feature-flagged 🎁
ready-for-doc-reviewlabel there.