Skip to content

Make the "Create query" location workspace-specific#2769

Merged
shati-patel merged 2 commits intomainfrom
shati-patel/create-query-workspace
Aug 31, 2023
Merged

Make the "Create query" location workspace-specific#2769
shati-patel merged 2 commits intomainfrom
shati-patel/create-query-workspace

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

If a user picks a folder in which to create custom queries (createQuery.qlPackLocation), that should be saved in workspace settings, rather than global settings by default. See internal linked issue for details! 📦

I've also changed createQuery.autogenerateQlPacks to get written to workspace settings, for consistency. There's no harm either way, but I think we should default to workspace settings, and only write to global settings for "higher-level" settings (such as enabling/disabling telemetry) ⚙

Checklist

N/A—this is still feature-flagged 🎁

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel requested a review from a team as a code owner August 31, 2023 12:45
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Us I understand it, if a value has already been written the global settings, then we'll continue to use it. But if we write a new value it'll go to workspace settings. So in that way it's compatible with existing data and that's good.

@shati-patel
Copy link
Copy Markdown
Contributor Author

As I understand it, if a value has already been written the global settings, then we'll continue to use it. But if we write a new value it'll go to workspace settings. So in that way it's compatible with existing data and that's good.

That's exactly right! Thanks ✨

@shati-patel shati-patel merged commit 66f12bf into main Aug 31, 2023
@shati-patel shati-patel deleted the shati-patel/create-query-workspace branch August 31, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants