Skip to content

Adjust styling of disabled dropdowns when automodeling is in progress#2785

Merged
robertbrignull merged 3 commits intomainfrom
robertbrignull/in-progress-dropdown
Sep 7, 2023
Merged

Adjust styling of disabled dropdowns when automodeling is in progress#2785
robertbrignull merged 3 commits intomainfrom
robertbrignull/in-progress-dropdown

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull commented Sep 5, 2023

This changes the dropdowns when the automodeling process is in progress. The Dropdown component now has new features that we can make use of.

Previously, we showed a usable dropdown, except that the only available option was "Thinking...". But the user could still click on the dropdown and it was a little odd.

Now, we show a disabled dropdown that the user cannot click on. The dropdown is still showing the "Thinking..." text.

I recommend checking out the storybook to see what it looks like.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested review from a team as code owners September 5, 2023 16:07
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 ✔️

@robertbrignull robertbrignull merged commit 5922bdf into main Sep 7, 2023
@robertbrignull robertbrignull deleted the robertbrignull/in-progress-dropdown branch September 7, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants