Adjust styling of disabled dropdowns when automodeling is in progress#2785
Merged
robertbrignull merged 3 commits intomainfrom Sep 7, 2023
Merged
Adjust styling of disabled dropdowns when automodeling is in progress#2785robertbrignull merged 3 commits intomainfrom
robertbrignull merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the dropdowns when the automodeling process is in progress. The
Dropdowncomponent now has new features that we can make use of.Previously, we showed a usable dropdown, except that the only available option was "Thinking...". But the user could still click on the dropdown and it was a little odd.
Now, we show a disabled dropdown that the user cannot click on. The dropdown is still showing the "Thinking..." text.
I recommend checking out the storybook to see what it looks like.
Checklist
ready-for-doc-reviewlabel there.