Add a row to the model editor tables showing how many methods have been hidden#2800
Merged
robertbrignull merged 5 commits intomainfrom Sep 12, 2023
Merged
Conversation
koesie10
approved these changes
Sep 11, 2023
Member
koesie10
left a comment
koesie10
left a comment
There was a problem hiding this comment.
LGTM, just some minor suggestions
Contributor
Author
|
Review suggestions applied and I've tested it manually and it still looks good. |
koesie10
approved these changes
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim of this is help users understand the effect of the "Hide modeled APIs" option. So if methods are hidden then we'll show how many there were. This PR also improves the experience when the table all methods are hidden by not showing the table header when there is no table content.
Screenshot showing a non-empty and empty table:
Suggestions about styling very welcome.
Checklist
ready-for-doc-reviewlabel there.