Skip to content

Renames remaining references to "external API usage" in the code#2806

Merged
robertbrignull merged 3 commits intomainfrom
robertbrignull/rename_externalApiUsages
Sep 12, 2023
Merged

Renames remaining references to "external API usage" in the code#2806
robertbrignull merged 3 commits intomainfrom
robertbrignull/rename_externalApiUsages

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

All references to "external API usage" should be renamed to "method" but I spotted a couple of references remaining in the code.

None of these changes are user-visible.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team as a code owner September 12, 2023 13:14
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Comment thread extensions/ql-vscode/test/unit-tests/model-editor/bqrs.test.ts Outdated
Comment thread extensions/ql-vscode/test/unit-tests/model-editor/bqrs.test.ts Outdated
@robertbrignull robertbrignull merged commit b424157 into main Sep 12, 2023
@robertbrignull robertbrignull deleted the robertbrignull/rename_externalApiUsages branch September 12, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants