Skip to content

Rename hideModeledApis => hideModeledMethods throughout the code#2808

Merged
robertbrignull merged 2 commits intomainfrom
robertbrignull/rename_hideModeledMethods_code
Sep 12, 2023
Merged

Rename hideModeledApis => hideModeledMethods throughout the code#2808
robertbrignull merged 2 commits intomainfrom
robertbrignull/rename_hideModeledMethods_code

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

Renames all variables and other code called "hideModeledApis" to "hideModeledMethods" instead.

No changes in this PR are user-visible. See #2807 for the PR that changes the UI.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one question inline 🚢

Comment thread extensions/ql-vscode/src/model-editor/model-editor-view.ts Outdated
Comment thread extensions/ql-vscode/src/model-editor/model-editor-view.ts Outdated
@robertbrignull robertbrignull merged commit 0a705a6 into main Sep 12, 2023
@robertbrignull robertbrignull deleted the robertbrignull/rename_hideModeledMethods_code branch September 12, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants