Code Search: don't show rate limit warnings to users #2812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koesie10
reviewed
Sep 14, 2023
| }>, | ||
| token: CancellationToken, | ||
| credentials: Credentials, | ||
| logger: NotificationLogger, |
Member
There was a problem hiding this comment.
To make this easier to test, I think we should keep using the logger (although it can be the BaseLogger instead of the NotificationLogger) instead of importing extLogger directly. I think we're moving away from importing extLogger directly and always trying to use a Logger interface.
norascheuch
force-pushed
the
nora/remove-rate-limit-code-search
branch
from
64a0a60 to
7af8b7a
Compare
koesie10
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of removing the information completely we will show primary and secondary rate limit information in the extension output.
Checklist
ready-for-doc-reviewlabel there.