Remove unnecessary activationEvents from extension's package.json#2815
Remove unnecessary activationEvents from extension's package.json#2815norascheuch merged 2 commits intomainfrom
activationEvents from extension's package.json#2815Conversation
koesie10
left a comment
koesie10
left a comment
There was a problem hiding this comment.
To do this, we first need to ensure we only support VS Code version 1.74.0 and up. I've placed a link in the internal issue to the process we need to follow to do that.
norascheuch
force-pushed
the
nora/remove-unused-activation-events
branch
from
076d15e to
f53ecde
Compare
| }, | ||
| "activationEvents": [ | ||
| "onLanguage:ql", | ||
| "onLanguage:ql-summary", |
There was a problem hiding this comment.
Can this also be removed? It seems like this is also included in our contributes.languages.
There was a problem hiding this comment.
Yes indeed! In https://code.visualstudio.com/api/references/activation-events#onLanguage it's stated at some point. Thank you!
It's 'interesting' that we activate the extension when the evaluator-log.summary is opened (why?..) by defining a 'language' that is connected to this file.
There was a problem hiding this comment.
It seems like we do have some language support for summary files, so this is probably the easiest way to actually make VS Code use that language.
2 participants
From VS Code version 1.74.0 onwards, we no longer need some activations events.
Checklist
ready-for-doc-reviewlabel there.