Skip to content

Add some simple model editor React unit tests#2816

Merged
koesie10 merged 1 commit intomainfrom
koesie10/simple-model-editor-react-tests
Sep 15, 2023
Merged

Add some simple model editor React unit tests#2816
koesie10 merged 1 commit intomainfrom
koesie10/simple-model-editor-react-tests

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Sep 14, 2023

This adds or expands some simple React tests for these components:

  • HiddenMethodsRow
  • KindInput
  • MethodName
  • ModelingStatusIndicator

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review September 14, 2023 12:12
@koesie10 koesie10 requested a review from a team as a code owner September 14, 2023 12:12
robertbrignull
robertbrignull approved these changes Sep 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@koesie10 koesie10 merged commit 2a9c8ef into main Sep 15, 2023
@koesie10 koesie10 deleted the koesie10/simple-model-editor-react-tests branch September 15, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koesie10 @robertbrignull