Skip to content

Only download automodel query pack when relevant#2830

Merged
charisk merged 1 commit intomainfrom
charisk/conditional-automodel-pack
Sep 19, 2023
Merged

Only download automodel query pack when relevant#2830
charisk merged 1 commit intomainfrom
charisk/conditional-automodel-pack

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Sep 19, 2023

Only download the automodel query pack for java and only if the relevant feature flag is enabled.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner September 19, 2023 13:44
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@charisk charisk merged commit 651bc51 into main Sep 19, 2023
@charisk charisk deleted the charisk/conditional-automodel-pack branch September 19, 2023 14:11
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. And I tested it locally and it works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants