Skip to content

Update KindInput component to bring it inline with others#2843

Merged
charisk merged 2 commits intomainfrom
charisk/model-kind-dropdown
Sep 21, 2023
Merged

Update KindInput component to bring it inline with others#2843
charisk merged 2 commits intomainfrom
charisk/model-kind-dropdown

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Sep 20, 2023

Updates the KindInput component to make it more self contained and more in line with the other dropdown components (e.g. #2833).

Please review commit by commit - the first commit renames the component to ModelKindDropdown.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner September 20, 2023 15:06
koesie10
koesie10 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charisk charisk merged commit 3a1431c into main Sep 21, 2023
@charisk charisk deleted the charisk/model-kind-dropdown branch September 21, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koesie10 koesie10 koesie10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @koesie10