Add ability to filter DB view by language#2856
Merged
shati-patel merged 2 commits intomainfrom Sep 26, 2023
Merged
Conversation
shati-patel
force-pushed
the
shati-patel/db-language-filter
branch
from
d6db8f2 to
750c1be
Compare
shati-patel
commented
Sep 25, 2023
Comment on lines
+63
to
+73
| enum LanguageFilter { | ||
| All = "All", | ||
| Cpp = QueryLanguage.Cpp, | ||
| CSharp = QueryLanguage.CSharp, | ||
| Go = QueryLanguage.Go, | ||
| Java = QueryLanguage.Java, | ||
| Javascript = QueryLanguage.Javascript, | ||
| Python = QueryLanguage.Python, | ||
| Ruby = QueryLanguage.Ruby, | ||
| Swift = QueryLanguage.Swift, | ||
| } |
Contributor
Author
There was a problem hiding this comment.
It would be nice to avoid duplicating this language list again, but I wasn't sure how to do that 🙈
Contributor
There was a problem hiding this comment.
I think (from a quick skim on StackOverflow) you can do something like
type LanguageFilter = QueryLanguage | 'All'to reuse the constants, then you have to reference the constants in the code as either QueryLanguage.<language> or All.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a language menu to the databases view:
db-language-filter.mp4
Reviewing notes
local-databases-ui.ts.Checklist
canaryflag, since it's still WIP. No user-facing changes yet.ready-for-doc-reviewlabel there.