Indicate which language is selected in the databases view#2871
Merged
shati-patel merged 3 commits intomainfrom Sep 28, 2023
Merged
Indicate which language is selected in the databases view#2871shati-patel merged 3 commits intomainfrom
shati-patel merged 3 commits intomainfrom
Conversation
shati-patel
commented
Sep 27, 2023
This reverts commit 7f47b79.
starcke
approved these changes
Sep 28, 2023
Contributor
starcke
left a comment
starcke
left a comment
There was a problem hiding this comment.
It is not the prettiest implementation, but we dont know of a better way.
| "title": "All languages" | ||
| }, | ||
| { | ||
| "command": "codeQLDatabases.displayAllLanguagesSelected", |
Contributor
There was a problem hiding this comment.
It is a bit tedious that we have to do it in this way. But maybe we can get a better way later.
|
|
||
| private async handleChangeLanguageFilter(languageFilter: LanguageFilter) { | ||
| this.treeDataProvider.languageFilter = languageFilter; | ||
| await this.app.commands.execute( |
Contributor
There was a problem hiding this comment.
This probably conflicts a little with #2873 but I am fine with the PRs going in either order.
Contributor
Author
|
Thanks for the review! I'll merge this PR now, but let me know if I can help with any conflicts |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
(selected)after the selected language in the databases view:db-language-selected.mp4
There's no public VS Code API for properly selecting a menu item (microsoft/vscode#109306), so adding a separate
...Selectedcommand was the closest workaround I could find 😢 See internal issue, where we discussed a bit more.Checklist
Still behind "canary", so no user-facing changes for now.
ready-for-doc-reviewlabel there.