Skip to content

Update model editor C# query to return method parameters with parentheses#2875

Merged
koesie10 merged 1 commit intomainfrom
koesie10/update-csharp-query
Sep 28, 2023
Merged

Update model editor C# query to return method parameters with parentheses#2875
koesie10 merged 1 commit intomainfrom
koesie10/update-csharp-query

Conversation

@koesie10
Copy link
Copy Markdown
Member

This updates the C# model editor query to implement github/codeql#14330. It also removes some post-processing which we had to do because of this difference.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review September 28, 2023 11:12
@koesie10 koesie10 requested a review from a team as a code owner September 28, 2023 11:12
@koesie10 koesie10 requested a review from starcke September 28, 2023 12:01
Copy link
Copy Markdown
Contributor

@starcke starcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@koesie10 koesie10 merged commit 6aab4b4 into main Sep 28, 2023
@koesie10 koesie10 deleted the koesie10/update-csharp-query branch September 28, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants